Add better validation for EirCode IE #1234
Merged
+6
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was implementing the isPostalCode and was looking for Ireland's postal code (eircode). Looking in the documentation of Ireland i found that the letter O is not used to avoid confusion with the digit 0.
Old regex
/^[A-z]\d[\d|w]\s\w{4}$/i
In this code the pipe
|
is literally a check on the if the|
as a char is present, and not the or sign.New regex
/^(?!.*(?:o))[A-z]\d[\dw]\s\w{4}$/i
In this code we check if there is in the whole string the character
O
is present if there is the regex don't match.Documentation
documentation eircode.ie
eircode-routing-keys
regex101